Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule] Fix tensorcore winograd task extraction #13625

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

masahi
Copy link
Member

@masahi masahi commented Dec 15, 2022

When both AutoTVM and AS/MS winograd are applicable, the latter is never picked by the op strategy because the AutoTVM one has a higher plevel (20 vs 15)

strategy.add_implementation(
wrap_compute_conv2d(topi.cuda.conv2d_nhwc_tensorcore),
wrap_topi_schedule(topi.cuda.schedule_conv2d_nhwc_tensorcore),
name="conv2d_nhwc_tensorcore.cuda",
plevel=20,
)

This has been fixed, and now we can properly extract FP16 winograd tasks for MS tuning.

@vinx13 @junrushao @zxybazh

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 15, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I was completely unaware of the issue, and thanks for pointing it out!

@masahi masahi force-pushed the ms-winograd-task-extraction-fix branch from 500cfcf to 25c235c Compare December 15, 2022 23:29
@masahi masahi merged commit 37f6aa0 into apache:main Dec 16, 2022
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* [MetaSchedule] Fix tensorcore winograd task extraction

* add test

* fixed target
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
* [MetaSchedule] Fix tensorcore winograd task extraction

* add test

* fixed target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants