Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR][OP][API-CHANGE] Remove CallNode.call_type in favor of attribute. #5937

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Jun 26, 2020

This is a followup refactor for tir::Call.
Now that we have switched call->name to call->op, the function effect property
can be registered through the op itself, so we no longer need the call_type in the CallNode.

  • Introduce CallEffectKind to provide a more fine grained categorization of calls.
  • Introduce call_pure_extern and call_llvm_pure_intrin to
    allow us to indicate pure calls in those cases.
  • Migrate existing usecases to the new API.

Upgrade Note

  • call type is no longer needed
  • call_pure_intrin => call_intrin as the pure information is in the op

@tqchen
Copy link
Member Author

tqchen commented Jun 26, 2020

Followup of #5863

This is a followup refactor for tir::Call.
Now that we have switched call->name to call->op, the function effect property
can be registered through the op itself, so we no longer need the call_type in the CallNode.

- Introduce CallEffectKind to provide a more fine grained categorization of calls.
- Introduce call_pure_extern and call_llvm_pure_intrin to
  allow us to indicate pure calls in those cases.
- Migrate existing usecases to the new API.
@tqchen tqchen merged commit eb66fd9 into apache:master Jun 27, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
apache#5937)

This is a followup refactor for tir::Call.
Now that we have switched call->name to call->op, the function effect property
can be registered through the op itself, so we no longer need the call_type in the CallNode.

- Introduce CallEffectKind to provide a more fine grained categorization of calls.
- Introduce call_pure_extern and call_llvm_pure_intrin to
  allow us to indicate pure calls in those cases.
- Migrate existing usecases to the new API.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
apache#5937)

This is a followup refactor for tir::Call.
Now that we have switched call->name to call->op, the function effect property
can be registered through the op itself, so we no longer need the call_type in the CallNode.

- Introduce CallEffectKind to provide a more fine grained categorization of calls.
- Introduce call_pure_extern and call_llvm_pure_intrin to
  allow us to indicate pure calls in those cases.
- Migrate existing usecases to the new API.
@tqchen tqchen deleted the tir branch February 26, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants