[TUTORIAL][ANSOR] Using the template-free auto-scheduler on CPU #6488

merrymercy · 2020-09-16T01:20:08Z

Add a tutorial on how to auto-schedule a subgraph for CPU.

Any feedback on the API is welcomed.

cc @jcf94 @tqchen @junrushao1994 @comaniac @jwfromm

jcf94

Fine to me.

jcf94 · 2020-09-16T01:46:56Z

python/tvm/auto_scheduler/auto_schedule.py

@@ -156,16 +159,41 @@ def __init__(
        )


+def create_task(func, args, target, target_host=None, hardware_params=None):


I'm thinking about what's the different of calling SearchTask() directly, seems they just have different input parameters.

I notice that AutoTVM used an api of autotvm.task.create(), should we keep them the same?

Anyway, it's fine since we may continue to refine our APIs later.

Python does not support constructor overloading, so I have to create a new function for this.

I think both auto_scheduler.create_task and auto_scheduler.task.create are okay.

jcf94

Seems we can next migrate the tuning scripts here, and start to reproduce the op/subgraph performance in our paper based on the new master.

junrushao

LGTM

tmoreau89

Nice work! I've only left cosmetic comments.

tutorials/auto_scheduler/tune_matmul_x86.py

comaniac

LGTM. Just nits.

python/tvm/auto_scheduler/auto_schedule.py

tutorials/auto_scheduler/tune_matmul_x86.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

tmoreau89

Thanks @merrymercy LGTM

tutorials/auto_scheduler/tune_matmul_x86.py

mbaret

I've just had a quick play around with this tutorial and it looks good to me. There is one thing I wonder though, which is that even when I boost the number of trials it never seems to decide to inline the bias add (x86). Is this a limitation of Ansor or is inlining just not performant here?

merrymercy · 2020-09-16T16:29:50Z

@mbaret Good catch! It is actually a small bug introduced during the upstream. Now the bug is fixed and you can give it another try.
One of the most important advantages of Ansor is just to try different fusion strategies for an arbitrary subgraph. So it should try both inline and no inline.

mbaret · 2020-09-16T17:28:34Z

Ah nice, it's working as I expected now.

binarybana · 2020-09-16T21:25:45Z

tutorials/auto_scheduler/tune_matmul_x86.py

+# We can kick off the search and let the auto-scheduler do its magic.
+# After some measurement trials, it will return the best schedule it found.
+
+sch, args = auto_scheduler.auto_schedule(task, tuning_options=tune_option)


It'd be nice to briefly describe what the return values of sch and args are here. I'm assuming that sch is a schedule, but is it encoded in TIR, or some other data structure? Same with args.

If you check the doc string of the auto_scheduler.auto_schedule(), you'll find the explaination of the return values: A te.schedule and the a list of te.Tensor to be used in tvm.lower or tvm.build.

I merged this first and will see whether the docstring link on the tvm website works.
If it is not working, I can add more explanations in the next PR, which is a similar tutorial for GPU.

…he#6488) * add tutorial * add tutorial * update * Apply suggestions from code review Co-authored-by: Cody Yu <comaniac0422@gmail.com> * address comments * fix bugs * add the exmple for resuming the search * fix lint Co-authored-by: Cody Yu <comaniac0422@gmail.com>

add tutorial

d9eb9e7

merrymercy changed the title ~~[AutoScheduler] Tutorial on how to auto-schedule a subgraph for CPU~~ [TUTORIAL] Using the template-free auto-scheduler on CPU Sep 16, 2020

add tutorial

48aa0e9

merrymercy force-pushed the ansor-cpu-tutorial branch from bd9c903 to 48aa0e9 Compare September 16, 2020 01:34

update

a943a32

jcf94 reviewed Sep 16, 2020

View reviewed changes

merrymercy changed the title ~~[TUTORIAL] Using the template-free auto-scheduler on CPU~~ [TUTORIAL][ANSOR] Using the template-free auto-scheduler on CPU Sep 16, 2020

jcf94 approved these changes Sep 16, 2020

View reviewed changes

junrushao approved these changes Sep 16, 2020

View reviewed changes

tqchen added the status: need review label Sep 16, 2020

tqchen approved these changes Sep 16, 2020

View reviewed changes

tmoreau89 reviewed Sep 16, 2020

View reviewed changes

comaniac approved these changes Sep 16, 2020

View reviewed changes

python/tvm/auto_scheduler/auto_schedule.py Outdated Show resolved Hide resolved

python/tvm/auto_scheduler/auto_schedule.py Outdated Show resolved Hide resolved

tutorials/auto_scheduler/tune_matmul_x86.py Outdated Show resolved Hide resolved

merrymercy and others added 2 commits September 15, 2020 20:50

Apply suggestions from code review

6dd4fd8

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

address comments

77725e7

tmoreau89 approved these changes Sep 16, 2020

View reviewed changes

masahi reviewed Sep 16, 2020

View reviewed changes

tutorials/auto_scheduler/tune_matmul_x86.py Outdated Show resolved Hide resolved

mbaret approved these changes Sep 16, 2020

View reviewed changes

fix bugs

9d418f8

add the exmple for resuming the search

5cad061

merrymercy force-pushed the ansor-cpu-tutorial branch from 59583c7 to 5cad061 Compare September 16, 2020 17:19

ZihengJiang added status: review in progress and removed status: need review labels Sep 16, 2020

fix lint

28bccef

binarybana reviewed Sep 16, 2020

View reviewed changes

merrymercy merged commit 8843e76 into apache:master Sep 17, 2020

merrymercy deleted the ansor-cpu-tutorial branch September 17, 2020 02:15

merrymercy removed the status: review in progress label Sep 17, 2020

comaniac mentioned this pull request Sep 25, 2020

[RFC] v0.7 Release Planning #6421

Closed

ZihengJiang mentioned this pull request Sep 25, 2020

TVM v0.7 Release Note Candidate #6486

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TUTORIAL][ANSOR] Using the template-free auto-scheduler on CPU #6488

[TUTORIAL][ANSOR] Using the template-free auto-scheduler on CPU #6488

merrymercy commented Sep 16, 2020 •

edited

Loading

jcf94 left a comment

jcf94 Sep 16, 2020 •

edited

Loading

merrymercy Sep 16, 2020

jcf94 left a comment •

edited

Loading

junrushao left a comment

tmoreau89 left a comment

comaniac left a comment

tmoreau89 left a comment

mbaret left a comment

merrymercy commented Sep 16, 2020 •

edited

Loading

mbaret commented Sep 16, 2020

binarybana Sep 16, 2020

jcf94 Sep 17, 2020

merrymercy Sep 17, 2020 •

edited

Loading

		@@ -156,16 +159,41 @@ def __init__(
		)


		def create_task(func, args, target, target_host=None, hardware_params=None):

[TUTORIAL][ANSOR] Using the template-free auto-scheduler on CPU #6488

[TUTORIAL][ANSOR] Using the template-free auto-scheduler on CPU #6488

Conversation

merrymercy commented Sep 16, 2020 • edited Loading

jcf94 left a comment

Choose a reason for hiding this comment

jcf94 Sep 16, 2020 • edited Loading

Choose a reason for hiding this comment

merrymercy Sep 16, 2020

Choose a reason for hiding this comment

jcf94 left a comment • edited Loading

Choose a reason for hiding this comment

junrushao left a comment

Choose a reason for hiding this comment

tmoreau89 left a comment

Choose a reason for hiding this comment

comaniac left a comment

Choose a reason for hiding this comment

tmoreau89 left a comment

Choose a reason for hiding this comment

mbaret left a comment

Choose a reason for hiding this comment

merrymercy commented Sep 16, 2020 • edited Loading

mbaret commented Sep 16, 2020

binarybana Sep 16, 2020

Choose a reason for hiding this comment

jcf94 Sep 17, 2020

Choose a reason for hiding this comment

merrymercy Sep 17, 2020 • edited Loading

Choose a reason for hiding this comment

merrymercy commented Sep 16, 2020 •

edited

Loading

jcf94 Sep 16, 2020 •

edited

Loading

jcf94 left a comment •

edited

Loading

merrymercy commented Sep 16, 2020 •

edited

Loading

merrymercy Sep 17, 2020 •

edited

Loading