[ShapeFunc] Handle weights in shape func #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemelon
approved these changes
Nov 14, 2020
src/relay/backend/compile_engine.cc
Outdated
| "shape_const", topi::kBroadcast); | ||
| scalars_.push_back(value); | ||
| return {value}; | ||
| } else { |
There was a problem hiding this comment.
No need for else since you already return.
|
Thanks @zhiics @icemelon9 This is merged. |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Nov 20, 2020
* [ShapeFunc] Handle weights in shape func
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
* [ShapeFunc] Handle weights in shape func * Comments
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
* [ShapeFunc] Handle weights in shape func * Comments
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
* [ShapeFunc] Handle weights in shape func * Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling a dynamic model with TRT, the primitive function has constants already bound in the graph. TVM codegen typically lifts those into variables in ANF pass, so we never see this problem in TVM codegen.
@icemelon9 @zhiics @codeislife99 @rohanmukh @trevor-m