Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm][Auto scheduler] Support Auto scheduler and NHWC convolution on ROCm #7038

Merged
merged 6 commits into from
Dec 6, 2020

Conversation

masahi
Copy link
Member

@masahi masahi commented Dec 5, 2020

  • Support HW param for rocm
  • Add NHWC convolution and winograd to rocm op strategy
  • Run IR analysis passes on rcom

Related discussion
https://discuss.tvm.apache.org/t/auto-schedular-performance-on-amdgpu-the-first-attempt/8582

please review @merrymercy @comaniac

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a nit and feel free to ignore.

src/auto_scheduler/search_task.cc Outdated Show resolved Hide resolved
src/auto_scheduler/feature.cc Outdated Show resolved Hide resolved
src/auto_scheduler/search_task.cc Outdated Show resolved Hide resolved
@masahi masahi changed the title [ROCm][Auto schedular] Support Auto schedular and NHWC convolution on ROCm [ROCm][Auto scheduler] Support Auto scheduler and NHWC convolution on ROCm Dec 5, 2020
@masahi
Copy link
Member Author

masahi commented Dec 5, 2020

will wait for #7040

@masahi masahi merged commit 3ec739c into apache:main Dec 6, 2020
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
… ROCm (apache#7038)

* add nhwc + winograd support to rocm strategy

* support rocm hw parameters in search task

* run analysis pass for rocm too

* run black

* pylint fix

* use IsGPUTask function

Co-authored-by: Masahiro Masuda <masahi@129@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
… ROCm (apache#7038)

* add nhwc + winograd support to rocm strategy

* support rocm hw parameters in search task

* run analysis pass for rocm too

* run black

* pylint fix

* use IsGPUTask function

Co-authored-by: Masahiro Masuda <masahi@129@gmail.com>
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
… ROCm (apache#7038)

* add nhwc + winograd support to rocm strategy

* support rocm hw parameters in search task

* run analysis pass for rocm too

* run black

* pylint fix

* use IsGPUTask function

Co-authored-by: Masahiro Masuda <masahi@129@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants