Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Frontend[Onnx] Add testing for output datatypes and fix related bugs. #7364

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

jwfromm
Copy link
Contributor

@jwfromm jwfromm commented Jan 28, 2021

@masahi encountered a bug due to our importer using int32 for topk rather than onnx's specified int64. To prevent similar errors, I've added an output datatype check to our onnx tests. This check uncovered a datatype mismatch in ArgMin and ArgMax that are also fixed in this PR.

@masahi
Copy link
Member

masahi commented Jan 28, 2021

please fix the lint issue

@masahi masahi merged commit f7862e7 into apache:main Jan 29, 2021
@masahi
Copy link
Member

masahi commented Jan 29, 2021

thanks @jwfromm @mbrookhart

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 11, 2021
…ed bugs. (apache#7364)

* Add testing for datatypes and fix related bugs.

* Fix lint issue in onnx.
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
…ed bugs. (apache#7364)

* Add testing for datatypes and fix related bugs.

* Fix lint issue in onnx.
Lokiiiiii pushed a commit to Lokiiiiii/tvm that referenced this pull request Mar 2, 2021
…ed bugs. (apache#7364)

* Add testing for datatypes and fix related bugs.

* Fix lint issue in onnx.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2021
…ed bugs. (apache#7364)

* Add testing for datatypes and fix related bugs.

* Fix lint issue in onnx.
@jwfromm jwfromm deleted the onnx_datatype_consistency branch April 12, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants