[BYOC][Verilator] Refactor Verilator runtime #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangfu
reviewed
Feb 16, 2021
| auto dealloc = reinterpret_cast<VerilatorDeallocFunc>(lib_->GetSymbol("VerilatorDealloc")); | ||
| ICHECK(dealloc != nullptr); | ||
| dealloc(device_); | ||
| lib_->~VerilatorLibrary(); |
There was a problem hiding this comment.
just out of curiosity, why do we explicitly call the deallocator instead of delete lib_?
liangfu
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Thanks @vegaluisjose for bringing the change, especially in enabling the profiler feature. The implementation looks good.
Free feel to merge when you think this is ready to merge. @vegaluisjose
|
Thank you @vegaluisjose @liangfu , the PR has been merged. |
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* new experiment * save * refactor * refactor library * add profiler * refactor * refactor * add docs * update comment * add deallocator
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* new experiment * save * refactor * refactor library * add profiler * refactor * refactor * add docs * update comment * add deallocator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Verilator runtime to support multiple options, including enabling a profiler for hardware designs that support performance counters. Also, I added some documentation to header files.
After this gets merged, my next goal is to update the Verilator app in VTA to showcase how this profiling information can be used when running actual models.
@tmoreau89 @liangfu