Simplify full broadcast #7423
Merged
Simplify full broadcast #7423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 9, 2021 12:15
mbrookhart
force-pushed
the
simplify_full_broadcast
branch
from
70572c8
to
7693107
Compare
masahi
reviewed
Feb 9, 2021
vinx13
approved these changes
Feb 10, 2021
|
Thanks @mbrookhart @masahi |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* convert argwhere(full(const)) to reshape(arange()) * Add IsWildcard syntatic sugar * add a simplify expression to fold full into broadcast ops * Allow constant folding of full-like ops after SimplifyExpr * fix a bug with the Attr Pattern matching * remove skip_list
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* convert argwhere(full(const)) to reshape(arange()) * Add IsWildcard syntatic sugar * add a simplify expression to fold full into broadcast ops * Allow constant folding of full-like ops after SimplifyExpr * fix a bug with the Attr Pattern matching * remove skip_list
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* convert argwhere(full(const)) to reshape(arange()) * Add IsWildcard syntatic sugar * add a simplify expression to fold full into broadcast ops * Allow constant folding of full-like ops after SimplifyExpr * fix a bug with the Attr Pattern matching * remove skip_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies full like ops that can be fused into broadcast ops, such that we can enable constant folding these ops in other situations to fix various issues we've seen with dynamic models.
This also refactors the SimplifyExpr pass somewhat to ease the addition of future patterns.
@vinx13 @jwfromm @icemelon9