Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Make TVM Rust bindings installable via Cargo. #7503

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

jroesch
Copy link
Member

@jroesch jroesch commented Feb 23, 2021

This builds on #7085 and is blocked on that merging. This PR makes it possible for us to release crates which can complete the entire TVM installation without needing users to build TVM.

@tqchen
Copy link
Member

tqchen commented Mar 3, 2021

@jroesch please fix the lint error(adding ASF header comments to the markdown files)

@tqchen tqchen added the status: need update need update based on feedbacks label Mar 3, 2021
@schell
Copy link
Contributor

schell commented Mar 10, 2021

This PR is great. Thank you!

@schell
Copy link
Contributor

schell commented Mar 17, 2021

It would be really great to get this merged, if possible.

@schell
Copy link
Contributor

schell commented Mar 24, 2021

Any luck @jroesch @tqchen ?

@jroesch
Copy link
Member Author

jroesch commented Mar 26, 2021

@schell sorry I got really busy with some parallel work at OctoML and I didn't realize anyone was blocked on this, will try and land over the weekend! sorry for the latency here the Rust bindings traditionally haven't seen as much use as I would like and can become lower priority.

@schell
Copy link
Contributor

schell commented Mar 27, 2021

No worries @jroesch, thank you!

@jwfromm
Copy link
Contributor

jwfromm commented Mar 31, 2021

@jroesch can you take a look at the CI? Hopefully this is close, I just want to keep it on your radar.

@jroesch jroesch mentioned this pull request Mar 31, 2021
@jroesch
Copy link
Member Author

jroesch commented Mar 31, 2021

@jwfromm As part of updating the Rust code we need some new dependencies in the CI containers just waiting for them to land in master and we can trigger a build, there was unfortunately a series of different changes which interacted poorly in CI leading to this breaking on this branch.

@jwfromm
Copy link
Contributor

jwfromm commented Apr 1, 2021

@jroesch, #7773 just merged, can you retrigger CI?

@jroesch jroesch force-pushed the rust-tvm-build branch 3 times, most recently from f659212 to b6f98c0 Compare April 1, 2021 18:51
@jroesch
Copy link
Member Author

jroesch commented Apr 1, 2021

Disabled a few things so this can land in parallel with my CI updates which might take a little longer to an underlying issue with GPU configuration (nothing to do with these changes but prevents updating the Docker image).

@jroesch jroesch force-pushed the rust-tvm-build branch 2 times, most recently from faa290a to c288273 Compare April 6, 2021 20:33
jroesch and others added 2 commits April 6, 2021 13:38
Rewrite the Rust Module API and change some imports causing crashes.

This commit also updates the docs to remove outdated information.

Fixes for version bump

Update build.rs to use new tvm-build version

Tweak build.rs to use release version of tvm-build

Add docs

Add Readme for tvm-sys crate.

Fix Cargo verisions for pre-release

Add README

Move generated code to OUT_DIR

Fix path

Add descp for tvm-sys

Tweak versions for publishing

Tweak versions for publishing

Add README for tvm-graph-rt

Conform to Apache branding guidelines

Fix caps

Add header

Remove warning

Format

Clean up build

Turn docs back on

Tweak CI

WIP

Remove CI changes
@@ -17,7 +17,7 @@

[package]
name = "tvm-graph-rt"
version = "0.1.0"
version = "0.1.0-alpha"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come you bumped to -alpha but didn't increment any other number?

@@ -17,7 +17,7 @@

[package]
name = "tvm-rt"
version = "0.1.0"
version = "0.1.0-alpha"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question

@@ -36,7 +36,7 @@ blas = ["ndarray/blas"]
python = ["pyo3"]

[dependencies.tvm-rt]
version = "0.1"
version = "0.1.0-alpha"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question

@jroesch
Copy link
Member Author

jroesch commented Apr 8, 2021

@areusch The packages of previously released packages had to be bumped to 1.1 while previous packages were at 1.0. We can unify the version numbering when we officially release them. I need to turn CI back on next before we can fix version numbers and issue a release.

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good, we can re-evaluate when CI is switched back on

@areusch areusch merged commit 648f53a into apache:main Apr 8, 2021
@schell
Copy link
Contributor

schell commented Apr 8, 2021

🎉

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* Make TVM Cargo installable

Rewrite the Rust Module API and change some imports causing crashes.

This commit also updates the docs to remove outdated information.

Fixes for version bump

Update build.rs to use new tvm-build version

Tweak build.rs to use release version of tvm-build

Add docs

Add Readme for tvm-sys crate.

Fix Cargo verisions for pre-release

Add README

Move generated code to OUT_DIR

Fix path

Add descp for tvm-sys

Tweak versions for publishing

Tweak versions for publishing

Add README for tvm-graph-rt

Conform to Apache branding guidelines

Fix caps

Add header

Remove warning

Format

Clean up build

Turn docs back on

Tweak CI

WIP

Remove CI changes

* Disable docs

* Fix
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* Make TVM Cargo installable

Rewrite the Rust Module API and change some imports causing crashes.

This commit also updates the docs to remove outdated information.

Fixes for version bump

Update build.rs to use new tvm-build version

Tweak build.rs to use release version of tvm-build

Add docs

Add Readme for tvm-sys crate.

Fix Cargo verisions for pre-release

Add README

Move generated code to OUT_DIR

Fix path

Add descp for tvm-sys

Tweak versions for publishing

Tweak versions for publishing

Add README for tvm-graph-rt

Conform to Apache branding guidelines

Fix caps

Add header

Remove warning

Format

Clean up build

Turn docs back on

Tweak CI

WIP

Remove CI changes

* Disable docs

* Fix
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
* Make TVM Cargo installable

Rewrite the Rust Module API and change some imports causing crashes.

This commit also updates the docs to remove outdated information.

Fixes for version bump

Update build.rs to use new tvm-build version

Tweak build.rs to use release version of tvm-build

Add docs

Add Readme for tvm-sys crate.

Fix Cargo verisions for pre-release

Add README

Move generated code to OUT_DIR

Fix path

Add descp for tvm-sys

Tweak versions for publishing

Tweak versions for publishing

Add README for tvm-graph-rt

Conform to Apache branding guidelines

Fix caps

Add header

Remove warning

Format

Clean up build

Turn docs back on

Tweak CI

WIP

Remove CI changes

* Disable docs

* Fix
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
* Make TVM Cargo installable

Rewrite the Rust Module API and change some imports causing crashes.

This commit also updates the docs to remove outdated information.

Fixes for version bump

Update build.rs to use new tvm-build version

Tweak build.rs to use release version of tvm-build

Add docs

Add Readme for tvm-sys crate.

Fix Cargo verisions for pre-release

Add README

Move generated code to OUT_DIR

Fix path

Add descp for tvm-sys

Tweak versions for publishing

Tweak versions for publishing

Add README for tvm-graph-rt

Conform to Apache branding guidelines

Fix caps

Add header

Remove warning

Format

Clean up build

Turn docs back on

Tweak CI

WIP

Remove CI changes

* Disable docs

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: need update need update based on feedbacks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants