[FIX] Fix autoscheduler tuning on sparse matrices where there are multiple with the same shape #7974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple with the same shape
jcf94
approved these changes
May 6, 2021
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…tiple with the same shape (apache#7974) * [FIX] Fix autoscheduler tuning on sparse matrices where there are multiple with the same shape * formatting * remove unreachable code
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…tiple with the same shape (apache#7974) * [FIX] Fix autoscheduler tuning on sparse matrices where there are multiple with the same shape * formatting * remove unreachable code
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…tiple with the same shape (apache#7974) * [FIX] Fix autoscheduler tuning on sparse matrices where there are multiple with the same shape * formatting * remove unreachable code
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…tiple with the same shape (apache#7974) * [FIX] Fix autoscheduler tuning on sparse matrices where there are multiple with the same shape * formatting * remove unreachable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the autoscheduler sparse matrix registration code more specific in regards to input shapes. Instead of using density (as a two digit float) to discriminate between different inputs, we use all the input shapes. This causes fewer collisions between specifier strings. However, there are still two sparse matrices in the
deploy_sparsetutorial that have the same specifier string. Ideally we would be able to use the values of the sparse matrix indices to discriminate between these two (for example, by hashing the indices), but the way registration is current setup makes this impossible. Instead we just ignore conflicts and hope that this doesn't cause a performance regression.@jcf94