Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorIR][M2a] Verification of cached flags #8114

Merged
merged 3 commits into from
May 25, 2021
Merged

[TensorIR][M2a] Verification of cached flags #8114

merged 3 commits into from
May 25, 2021

Conversation

junrushao
Copy link
Member

This PR is part of the TensorIR upstreaming effort (#7527), stage M2a.

In this PR, we implemented cached flag verification, which will check the correctness of the following flags if the schedule class is set to debug:

  • is_affine_binding
  • region_cover
  • is_stage_pipeline

To enable the detection of the region cover property, we also bring in several integer set analysis along with this PR.

@junrushao junrushao changed the title [TensorIR][M2a] Verification of cached flags (#390) [TensorIR][M2a] Verification of cached flags May 23, 2021
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
@junrushao
Copy link
Member Author

CC: @tqchen @jroesch @comaniac @icemelon9 @zhiics

src/arith/int_set.cc Outdated Show resolved Hide resolved
src/arith/int_set.cc Outdated Show resolved Hide resolved
src/arith/int_set.cc Outdated Show resolved Hide resolved
Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments on readability

src/tir/schedule/analysis/analysis.cc Show resolved Hide resolved
@tqchen tqchen self-assigned this May 24, 2021
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only nits and feel free to ignore.

src/tir/schedule/analysis/verify.cc Outdated Show resolved Hide resolved
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
@junrushao junrushao requested review from tqchen and comaniac May 25, 2021 00:01
@comaniac comaniac merged commit 47c8e47 into apache:main May 25, 2021
@comaniac
Copy link
Contributor

Thanks @junrushao1994 @tqchen

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
* [TensorIR][M2a] Verification of cached flags

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>

* Address comments

* Update src/tir/schedule/analysis/verify.cc

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
* [TensorIR][M2a] Verification of cached flags

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>

* Address comments

* Update src/tir/schedule/analysis/verify.cc

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants