-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay to Onnx][LRN] #8323
[Relay to Onnx][LRN] #8323
Conversation
schilkunda-amba
commented
Jun 24, 2021
- Added support for LRN operator in relay to onnx conversion
- Added unit test
* Added unit test case for LRN
* change single quotes to double * set space to 4 instead of 2
python/tvm/contrib/target/onnx.py
Outdated
"beta": attrs.beta, | ||
"bias": attrs.bias, | ||
"size": attrs.size | ||
# axis? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment.
It looks like the ONNX LRN op doesn't have an axis parameter, as it always applies to axis 1.
We should probably add assert somewhere to check that the axis is also 1 in the Relay operator that is being converted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added the axis check.
* Assert if axis != 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @schilkunda-amba!
* Added support for LRN operator * [Relay to Onnx] * Added unit test case for LRN * * reformatted * * reformatted (2) * * fixed formatting issues in relay to onnx conversion script * * fixed formatting * change single quotes to double * set space to 4 instead of 2 * * reformatted onnx.py: corrected spaces * [Relay to Onnx] LRN * Assert if axis != 1 * * fixed formatting Co-authored-by: zxy844288792 <zhoxingy@amazon.com>
* Added support for LRN operator * [Relay to Onnx] * Added unit test case for LRN * * reformatted * * reformatted (2) * * fixed formatting issues in relay to onnx conversion script * * fixed formatting * change single quotes to double * set space to 4 instead of 2 * * reformatted onnx.py: corrected spaces * [Relay to Onnx] LRN * Assert if axis != 1 * * fixed formatting Co-authored-by: zxy844288792 <zhoxingy@amazon.com>