Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorIR][M2a] Reduction Factoring (RFactor) #8544

Merged
merged 9 commits into from
Jul 31, 2021

Conversation

MasterJH5574
Copy link
Contributor

This PR is part of the TensorIR upstreaming effort (#7527), which adds the one schedule primitive "rfactor".

cc @junrushao1994 @tqchen @comaniac @jcf94

include/tvm/tir/stmt.h Outdated Show resolved Hide resolved
src/tir/ir/expr.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the core rfactor implement to tomorrow.
Also cc @jcf94 @vinx13 to help review.

include/tvm/tir/schedule/schedule.h Outdated Show resolved Hide resolved
include/tvm/tir/stmt.h Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Show resolved Hide resolved
python/tvm/tir/schedule/schedule.py Outdated Show resolved Hide resolved
tests/python/unittest/test_tir_schedule_reduction.py Outdated Show resolved Hide resolved
@tqchen tqchen added the status: need update need update based on feedbacks label Jul 27, 2021
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should be able to merge this PR when CI is green.

@comaniac comaniac removed the status: need update need update based on feedbacks label Jul 27, 2021
@tqchen
Copy link
Member

tqchen commented Jul 29, 2021

@MasterJH5574 , please fix the docstring issues. You can reproduce by following ./tests/scripts/task_sphinx_precheck.sh

@junrushao
Copy link
Member

@tqchen looks like this PR is experiencing CPU time out on unittests

@junrushao junrushao merged commit 5012462 into apache:main Jul 31, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants