[Coreml] Fix Coreml Input Shape Handling #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewZhaoLuo
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
AndrewZhaoLuo
changed the title
AndrewZhaoLuo
requested review from
areusch,
comaniac,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
AndrewZhaoLuo
changed the title
AndrewZhaoLuo
changed the title
tqchen
approved these changes
Jul 26, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* convert ot python list like expected * test example * jostle ci Co-authored-by: Andrew Zhao Luo <andrewzhaoluo@system76-pc.localdomain>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* convert ot python list like expected * test example * jostle ci Co-authored-by: Andrew Zhao Luo <andrewzhaoluo@system76-pc.localdomain>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input shape may not be a python list (which is what the ffi knows how to handle) but rather a rather complicated protobuf object. The solution is to just convert it to a python list.
Before:
TypeError: Don't know how to handle type <class 'google.protobuf.pyext._message.RepeatedScalarContainer'>
After:
Works! Now we just have an issue with unsupported ops.
Before:
Running this script: https://github.com/AndrewZhaoLuo/TVM-Sandbox/blob/bf3df0ee1dcc382a68cb551bc73826dff94b73b9/coreml_debug/coreml-test.py#L1
Fails with
TypeError: Don't know how to handle type <class 'google.protobuf.pyext._message.RepeatedScalarContainer'>Now:
It fails with an unsupported operator which the user can now add.