Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hot-fix][CI]Disable mypy for ethosu #9050

Closed
wants to merge 1 commit into from

Conversation

mikepapadim
Copy link
Contributor

Fix for failing CI on ethosu mypy sanity checks

@tqchen @mehrdadh

@tqchen
Copy link
Member

tqchen commented Sep 20, 2021

cc @manupa-arm

@manupak
Copy link
Contributor

manupak commented Sep 20, 2021

Thanks for catching this! Any idea why it did not fail before?

cc: @mbaret @ashutosh-arm

@mikepapadim
Copy link
Contributor Author

@manupa-arm it looks like the changes causing this one are from here #8806

@manupak
Copy link
Contributor

manupak commented Sep 20, 2021

Thanks @mikepapadim! but I believe it passed CI with those checks. Did anything change on the CI ?

@ashutosh-arm
Copy link
Contributor

ashutosh-arm commented Sep 20, 2021

Missing stub warnings can be fixed with this:

mypy --check-untyped-defs python/tvm/relay/backend/contrib/ethosu/ --ignore-missing-imports

@areusch
Copy link
Contributor

areusch commented Sep 20, 2021

this hit #9013, we also need to fix that.

@AndrewZhaoLuo
Copy link
Contributor

Can we set up a big red button that merges something without CI passing?

@mikepapadim
Copy link
Contributor Author

this hit #9013, we also need to fix that.

This bug hits also stagging Jenkins.

@mikepapadim
Copy link
Contributor Author

@areusch I think this PR can be closed if #9052 get through.

@junrushao
Copy link
Member

i dont think committers have permission to merge a pr without CI green. maybe it's a merge conflict?

@areusch
Copy link
Contributor

areusch commented Sep 22, 2021

i think we don't need this anymore. closing, feel free to reopen if we do need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants