[LLVM] Refactor MakeCallPacked, NFC #9118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
requested review from
junrushao,
masahi,
tqchen,
vinx13 and
ZihengJiang
as code owners
Change the interface for `MakeCallPacked` in `CodeGenCPU` and in `CodeGenHexagon` to encapsulate the multiple returned values into a single structure. This should help readability, but also it will make the upcoming adoption of opaque pointers a bit easier.
masahi
approved these changes
Sep 27, 2021
AndrewZhaoLuo
added a commit
to AndrewZhaoLuo/tvm
that referenced
this pull request
Sep 28, 2021
* main: (37 commits) [ONNX] [Relay] Dynamic squeeze (apache#9095) [Meta Schedule][M3b] Database (apache#9061) [Bugfix] Add nullptr checking for `AttrStmt` with `coproc_uop_scope` attr key (apache#9123) [Codegen] Swap out analyzer when outlining (apache#9117) [CI] bash.sh, build.sh: add option to set the container name and hostname (apache#9110) Ensure google-mock is installed and setup (apache#9107) Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D (apache#8811) Frontend: add onnx GlobalLpPool op (apache#8845) [LLVM] Refactor MakeCallPacked, NFC (apache#9118) prevent casting handle to other types (apache#9114) fix annotation of tir generic (apache#9119) [Relay] Register layout conversion function to more reduce ops (apache#9048) Fix the missing `dtype` attribute of `tir.Shuffle` in Python level (apache#9131) add `multiply` and remove `subtract` for dnnl json runtime (apache#9120) relu of dnnl json runtime only support 4-dims input (apache#9122) [Meta Schedule][M3a] SpaceGenerator (apache#9079) [TensorIR][Bugfix] Disallow fusing loops with dependency (apache#9112) adding Jorn to reviewers list (apache#9105) [BYOC] Fix incorrect conv2d padding handling of `dnnl with c source runtime` (apache#9097) [Frontend][TFLite] fix apache#9078 (apache#9099) ...
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
Change the interface for `MakeCallPacked` in `CodeGenCPU` and in `CodeGenHexagon` to encapsulate the multiple returned values into a single structure. This should help readability, but also it will make the upcoming adoption of opaque pointers a bit easier.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
Change the interface for `MakeCallPacked` in `CodeGenCPU` and in `CodeGenHexagon` to encapsulate the multiple returned values into a single structure. This should help readability, but also it will make the upcoming adoption of opaque pointers a bit easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the interface for
MakeCallPackedinCodeGenCPUand inCodeGenHexagonto encapsulate the multiple returned values into a single structure. This should help readability, but also it will make the upcoming adoption of opaque pointers a bit easier.