Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quantised RSQRT operator in TFLite #9165

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

ophirfrish
Copy link
Contributor

The commit tests _convert_unary_elemwise function for the quantized and
non quantized tensor for the RSQRT op.
Other operators will be tested in future (separated) commits.

cc @areusch @leandron @gromero @Mousius for reviews

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As @ophirfrish mentioned. This PR will open the opportunity for us to add other quantised operator support, in separate PRs, with appropriate testing, etc.

We’ll soon create a tracking issue for this list of operators.

The commit tests _convert_unary_elemwise function for the quantised and
non quantized tensor for the RSQRT op.
Other operators will be tested in future (separated )commits.
@leandron
Copy link
Contributor

leandron commented Oct 4, 2021

As all the tests are passing here, and the issue is sitting here for a few days, I'll merge it and we can take any required changes as follow-up patches.

For the potential operators that can be implemented in future, benefiting from this PR, we raised #9187.

Thanks @ophirfrish!

@leandron leandron merged commit b9f2284 into apache:main Oct 4, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
The commit tests _convert_unary_elemwise function for the quantised and
non quantized tensor for the RSQRT op.
Other operators will be tested in future (separated )commits.
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
The commit tests _convert_unary_elemwise function for the quantised and
non quantized tensor for the RSQRT op.
Other operators will be tested in future (separated )commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants