Fix group transpose conv2d #9443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicja-SiMa-ai
requested review from
anijain2305,
areusch,
comaniac,
Huyuwei,
icemelon,
jcf94,
jroesch,
junrushao,
jwfromm,
kevinthesun,
Laurawly,
MarisaKirisame,
masahi,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
Change includes topi implementation, tests, generic and x86 strategy for group transposed convolution. Signed-off-by: Alicja Kwasniewska <alicja.kwasniewska@sima.ai>
alicja-SiMa-ai
force-pushed
the
fix/group_transpose_conv2d
branch
from
7aa2efa
to
8eb15b7
Compare
|
Hmm is this perhaps related to #9336 ? |
|
@AndrewZhaoLuo #9336 changes the layout conversion. This PR addresses a different issue, it adds implementation of group transpose convolution 2D which was missing and fixes weight shape to support groups. |
vinx13
reviewed
Nov 8, 2021
There was a problem hiding this comment.
would be great to also add Relay tests here https://github.com/apache/tvm/blob/main/tests/python/relay/test_op_level2.py#L818
|
@Lyken17 @alicja-SiMa-ai just to double check, is this commit superseded via this commit 3ad7c4a? Thanks! |
|
Yes @junrushao1994, it was integrated into #9465. Closing this one. Thanks everyone! |
|
Thank you @alicja-SiMa-ai for the huge effort!! This is super helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shape of weights was incorrectly set for grouped transposed conv2D and implementation of the grouped transposed conv2D was missing. As a result, some models were not supported. Please see example of the CenterNet model here with error message
in particular dimension 1 conflicts 0 does not match 1; unable to unify: Tensor[(256, 0, 4, 4), float32] and Tensor[(256, 1, 4, 4), float32].This PR adds missing implementation and required tests.
cc @comaniac