Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI] Add generic batch norm #9694

Merged
merged 11 commits into from
Dec 13, 2021
Merged

[TOPI] Add generic batch norm #9694

merged 11 commits into from
Dec 13, 2021

Conversation

michalpiszczek
Copy link
Contributor

@michalpiszczek michalpiszczek commented Dec 9, 2021 •
edited
Loading

  • Add a TOPI implementation of batch norm so it can be constant folded
  • Add associated tests

@michalpiszczek
Copy link
Contributor Author

@mbrookhart PTAL

@michalpiszczek
Copy link
Contributor Author

@AndrewZhaoLuo @jwfromm PTAL

mbrookhart
mbrookhart requested changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a problem with the relay test, but otherwise it looks fantastic. Thank you!

tests/python/relay/test_op_level1.py Outdated Show resolved Hide resolved
mbrookhart
mbrookhart approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbrookhart mbrookhart merged commit cb34604 into apache:main Dec 13, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@michalpiszczek @ylc
[TOPI] Add generic batch norm (apache#9694)
7434cd0 
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
@michalpiszczek @yangulei
[TOPI] Add generic batch norm (apache#9694)
0eccb13 
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
@michalpiszczek @yangulei
[TOPI] Add generic batch norm (apache#9694)
09d2b8a 
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@michalpiszczek @ylc
[TOPI] Add generic batch norm (apache#9694)
f6cacc6 
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
qsqqsqqsq-intellif pushed a commit to qsqqsqqsq-intellif/tvm that referenced this pull request Apr 29, 2022
@michalpiszczek
[TOPI] Add generic batch norm (apache#9694)
fcf37f6 
* Add topi batch norm and tests

* Handle none values correctly

* Return correct nun outputs for onnx

* Use moving var/mean and update tests

* Add a test for batch norm folding

* Fix comment

* Format with black

* Re-order test args to match interface

* Call fold constant manually
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
@yuanfz98 yuanfz98 mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookhart mbrookhart mbrookhart approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

@icemelon icemelon Awaiting requested review from icemelon

@jcf94 jcf94 Awaiting requested review from jcf94

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@jwfromm jwfromm Awaiting requested review from jwfromm

@kazum kazum Awaiting requested review from kazum

@kevinthesun kevinthesun Awaiting requested review from kevinthesun

@Laurawly Laurawly Awaiting requested review from Laurawly

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@masahi masahi Awaiting requested review from masahi

@merrymercy merrymercy Awaiting requested review from merrymercy

@siju-samuel siju-samuel Awaiting requested review from siju-samuel

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@srkreddy1238 srkreddy1238 Awaiting requested review from srkreddy1238

@tqchen tqchen Awaiting requested review from tqchen

@vinx13 vinx13 Awaiting requested review from vinx13

@wweic wweic Awaiting requested review from wweic

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalpiszczek @mbrookhart