[Docker] Update to Torch 1.10.1 #9781
Conversation
masahi
requested review from
areusch,
comaniac,
Huyuwei,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
leandron,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
|
@masahi why revert the onnx upgrade we've been trying to get in? |
|
Because I think without revert, the new image would run tests with the new onnx version. @AndrewZhaoLuo updated the docker script but we haven't run any tests with the new ONNX in CI, so we don't know which tests are broken and need fixing. @AndrewZhaoLuo and I agreed that we update the PyTorch version first, and later he can follow my process to update ONNX. The ONNX CI update #9511 is apparently stalled partly because he (and I) are not familiar with the new protocol. But I can also wait a bit if @AndrewZhaoLuo wants to resume his work and get in the ONNX update first. |
masahi
force-pushed
the
torch-1.10-image-update
branch
from
0456eee
to
b53b2ba
Compare
masahi
force-pushed
the
torch-1.10-image-update
branch
from
b53b2ba
to
542be20
Compare
|
Yeah Im fine with this change, won't be working on this until after ~2 weeks. This will be also a good example on how to actually do this CI change. |
* update pytorch to 1.10.1 * fix missing import test only on llvm and cuda * Revert "[Docker][Onnx] Upgrade ONNX to latest version (apache#9519)" This reverts commit 3f5dca5. * skip testing if target is not enabled
* update pytorch to 1.10.1 * fix missing import test only on llvm and cuda * Revert "[Docker][Onnx] Upgrade ONNX to latest version (apache#9519)" This reverts commit 3f5dca5. * skip testing if target is not enabled
* update pytorch to 1.10.1 * fix missing import test only on llvm and cuda * Revert "[Docker][Onnx] Upgrade ONNX to latest version (apache#9519)" This reverts commit 3f5dca5. * skip testing if target is not enabled
Related issue #9713
This is for building a new nightly image with the new PyTorch version. The actual CI image update will come later.
This also reverts ONNX update in #9519, since @AndrewZhaoLuo didn't get to actually update the CI image and wants me to update Torch first.
@manupa-arm @leandron @comaniac