Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNNL-BYOC enhancement #9797

Merged
merged 2 commits into from
Dec 29, 2021
Merged

DNNL-BYOC enhancement #9797

merged 2 commits into from
Dec 29, 2021

Conversation

crazydemo
Copy link
Contributor

  • add more patterns in dnnl.py.
  • add test cases, which have covered the support ops and patterns, in test_dnnl.py.
  • add implementation of new added ops and patterns in dnnl_json_runtime.cc.
  • add support to dilated conv2d with dnnl backend.

@masahi masahi self-assigned this Dec 23, 2021
@crazydemo crazydemo force-pushed the dev-byoc_partition branch 4 times, most recently from e1a4a1b to b2abb2b Compare December 24, 2021 05:51
@crazydemo crazydemo force-pushed the dev-byoc_partition branch 2 times, most recently from 449b68a to ed87f71 Compare December 27, 2021 05:39
jwfromm
jwfromm reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, it looks really excellent. I have a few small comments but am curious if youve done any benchmarking with this new pattern fusion. If so, how much do these changes speed up models you tried?

tests/python/contrib/test_dnnl.py Outdated Show resolved Hide resolved
tests/python/relay/test_pass_partition_graph.py Outdated Show resolved Hide resolved
@crazydemo
Copy link
Contributor Author

Thanks for this change, it looks really excellent. I have a few small comments but am curious if youve done any benchmarking with this new pattern fusion. If so, how much do these changes speed up models you tried?

Thank you for your comments. We do have done some benchmark, and the related results are posted on RFC.

Note that, the results in RFC are collected with the registered pattern and optimization from alter_op_layout pass.
We are going to submit another two layout transform related PRs to fully support the performance gain claimed in RFC.

@masahi masahi merged commit 75cd670 into apache:main Dec 29, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@crazydemo @ylc
DNNL-BYOC enhancement (apache#9797)
12f71c2 
* add unit test for byoc-dnnl

* add byoc-dnnl pattern and their test cases
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@crazydemo @ylc
DNNL-BYOC enhancement (apache#9797)
536c27e 
* add unit test for byoc-dnnl

* add byoc-dnnl pattern and their test cases
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
liaopeiyuan added a commit to zk-ml/tachikoma that referenced this pull request Sep 15, 2022
@liaopeiyuan
incorporate apache#9797
c5116fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwfromm jwfromm jwfromm left review comments

@masahi masahi masahi approved these changes

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@areusch areusch Awaiting requested review from areusch

@comaniac comaniac Awaiting requested review from comaniac

@icemelon icemelon Awaiting requested review from icemelon

@jroesch jroesch Awaiting requested review from jroesch

@junrushao junrushao Awaiting requested review from junrushao

@kazum kazum Awaiting requested review from kazum

@liangfu liangfu Awaiting requested review from liangfu

@manupak manupak Awaiting requested review from manupak

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@mbaret mbaret Awaiting requested review from mbaret

@mbrookhart mbrookhart Awaiting requested review from mbrookhart

@merrymercy merrymercy Awaiting requested review from merrymercy

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@tmoreau89 tmoreau89 Awaiting requested review from tmoreau89

@tqchen tqchen Awaiting requested review from tqchen

@trevor-m trevor-m Awaiting requested review from trevor-m

@vinx13 vinx13 Awaiting requested review from vinx13

@wweic wweic Awaiting requested review from wweic

@yzhliu yzhliu Awaiting requested review from yzhliu

@zhiics zhiics Awaiting requested review from zhiics

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

Assignees

@masahi masahi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazydemo @masahi @jwfromm