[BugFix][TensorIR] Non-positive constant input factors for split
#9805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
requested review from
areusch,
comaniac,
Hzfengsy,
icemelon,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
Hzfengsy
approved these changes
Dec 26, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…pache#9805) * Update docs of GetProducers/GetConsumers * Fix split for non-positive factors
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…pache#9805) * Update docs of GetProducers/GetConsumers * Fix split for non-positive factors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug of TensorIR primitive
split. Prior to this PR, the primitive didn't error out for non-positive input factors.cc @jinhongyii @Hzfengsy