Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2450]Rename updateLowestId to updateLowestID, TestLoggerIds to TestLoggerIDs #973

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2450]Rename updateLowestId to updateLowestID, TestLoggerIds to TestLoggerIDs #973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/events/event_ringbuffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ func newEventRingBuffer(capacity uint64) *eventRingBuffer {
}

// called from Resize(), this function updates the lowest event id available in the buffer
func (e *eventRingBuffer) updateLowestId(beginSize, endSize uint64) {
func (e *eventRingBuffer) updateLowestID(beginSize, endSize uint64) {
// if buffer size is increasing, lowestId stays the same
if beginSize < endSize {
return
Expand Down Expand Up @@ -238,7 +238,7 @@ func (e *eventRingBuffer) Resize(newSize uint64) {
endIndex := (startIndex + numEventsToCopy - 1) % e.capacity

prevLowestId := e.getLowestID()
e.updateLowestId(initialSize, newSize)
e.updateLowestID(initialSize, newSize)
newLowestId := e.getLowestID()

if prevLowestId != newLowestId {
Expand Down
2 changes: 1 addition & 1 deletion pkg/log/logger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var logFile string

var iterations = 100000

func TestLoggerIds(t *testing.T) {
func TestLoggerIDs(t *testing.T) {
_ = Log(Test)

// validate logger count
Expand Down
Loading