Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In the test case
TestAssignedPod
, the comment is// the cached node has no pods assigned
, but we doassert.Equal(t, len(cachedNode.Pods), 1)
.In the test case
TestAddPod
, the comment is// assumed pod should no longer be assumed if node changes
, but we doassert.Check(t, cache.isAssumedPod(podUID1), "pod is not assumed")
.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1855
How should this be tested?
Screenshots (if appropriate)
Questions: