Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1855] fix comments #630

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

In the test case TestAssignedPod, the comment is // the cached node has no pods assigned, but we do assert.Equal(t, len(cachedNode.Pods), 1).

In the test case TestAddPod, the comment is // assumed pod should no longer be assumed if node changes, but we do assert.Check(t, cache.isAssumedPod(podUID1), "pod is not assumed").

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1855

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Signed-off-by: Frank Yang <yangpoan@gmail.com>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #630 (578790c) into master (1e34d5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #630   +/-   ##
=======================================
  Coverage   71.02%   71.02%           
=======================================
  Files          50       50           
  Lines        8183     8183           
=======================================
  Hits         5812     5812           
  Misses       2168     2168           
  Partials      203      203           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@FrankYang0529 FrankYang0529 deleted the YUNIKORN-1855 branch July 12, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants