Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1867] add priority offset e2e test #637

Closed
wants to merge 2 commits into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

Add priority.offset property e2e test.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1867

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #637 (1d433b5) into master (60a5cfe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files          52       52           
  Lines        8245     8245           
=======================================
  Hits         5846     5846           
  Misses       2195     2195           
  Partials      204      204           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing quite a few test failures on this, need to investigate and fix.

@FrankYang0529
Copy link
Member Author

Seeing quite a few test failures on this, need to investigate and fix.

The root cause of error test cases is that we can't add child queue to a draining queue. In the first case, we add three queues root.fence, root.fence.child1, and root.fence.child2. After we reset the configuration, these three queues will get into the draining state. Then, another case tries to add child queues to root.fence and the case gets error.

Currently, the yunikorn-core will clean draining queues every 10 seconds. The duration is hardcoded in the source code. Users can't update it. Do we want to add the setting to the configuration? If yes, I can help to add it.

CI failed job: https://github.com/apache/yunikorn-k8shim/actions/runs/5575867672/jobs/10202470269
Cleaning draining queues source code: https://github.com/apache/yunikorn-core/blob/129c0de6b12b21b4282631b2c0b6df188ce7ae80/pkg/scheduler/partition_manager.go#L70-L87

@craigcondit
Copy link
Contributor

A better approach is probably to use distinct queue names for different tests so that they don't conflict.

Signed-off-by: Frank Yang <yangpoan@gmail.com>
Signed-off-by: Frank Yang <yangpoan@gmail.com>
Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Change looked more complicated due to diff layout

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@FrankYang0529 FrankYang0529 deleted the YUNIKORN-1867 branch July 26, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants