Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1884] fix optedout #646

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

The yunikorn.apache.org/allow-preemption is an annotation key, but we put it in labels in e2e-test helper function.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1884

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Signed-off-by: Frank Yang <yangpoan@gmail.com>
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #646 (f0fcfe1) into master (ac8df79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #646   +/-   ##
=======================================
  Coverage   71.15%   71.15%           
=======================================
  Files          52       52           
  Lines        8258     8258           
=======================================
  Hits         5876     5876           
  Misses       2178     2178           
  Partials      204      204           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@pbacsko pbacsko closed this in 15d93f1 Aug 9, 2023
@FrankYang0529 FrankYang0529 deleted the YUNIKORN-1884 branch August 9, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants