Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-1902] remove Application CRD #650

Closed
wants to merge 1 commit into from

Conversation

FrankYang0529
Copy link
Member

What is this PR for?

Remove Application CRD and clean up the build.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1902

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Signed-off-by: Frank Yang <yangpoan@gmail.com>
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #650 (f746a60) into master (4cfbda0) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   71.19%   71.33%   +0.14%     
==========================================
  Files          52       51       -1     
  Lines        8276     8104     -172     
==========================================
- Hits         5892     5781     -111     
+ Misses       2180     2127      -53     
+ Partials      204      196       -8     
Files Changed Coverage Δ
pkg/appmgmt/interfaces/amprotocol.go 0.00% <ø> (ø)
pkg/dispatcher/dispatcher.go 77.30% <ø> (+2.47%) ⬆️
pkg/shim/scheduler.go 74.19% <ø> (-0.12%) ⬇️
pkg/appmgmt/appmgmt.go 57.81% <100.00%> (+8.46%) ⬆️
pkg/appmgmt/general/metadata.go 86.07% <100.00%> (ø)
pkg/cache/application.go 74.69% <100.00%> (-0.47%) ⬇️
pkg/cache/placeholder.go 92.85% <100.00%> (ø)
pkg/common/utils/gang_utils.go 89.09% <100.00%> (ø)
pkg/common/utils/utils.go 71.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@FrankYang0529 FrankYang0529 deleted the YUNIKORN-1902 branch August 8, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants