Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2851] Improve placeholder & placeholder_manger funtion's test coverage #905

Closed
wants to merge 1 commit into from

Conversation

SP12893678
Copy link
Contributor

What is this PR for?

Improver the following funtion's test coverage:

  • newPlaceholder (schedParamsDef not empty case)
  • cleanUp (delete pod error case)
  • cleanOrphanPlaceholders (delete pod error case)

What type of PR is it?

  • - Test

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2851

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.20%. Comparing base (f8e9c11) to head (fdbe5c1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
+ Coverage   68.04%   68.20%   +0.15%     
==========================================
  Files          70       70              
  Lines        7558     7558              
==========================================
+ Hits         5143     5155      +12     
+ Misses       2205     2197       -8     
+ Partials      210      206       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@SP12893678 SP12893678 deleted the YUNIKORN-2851 branch September 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants