Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2799] Solve dockerfile warning which emerged while building #910

Closed
wants to merge 1 commit into from

Conversation

ryankert01
Copy link
Contributor

@ryankert01 ryankert01 commented Sep 6, 2024

What is this PR for?

1 warning found:

  15 |     # See the License for the specific language governing permissions and
  16 |     # limitations under the License.
  17 | >>> FROM --platform=$TARGETPLATFORM scratch
  18 |     COPY --chown=0:0 LICENSE NOTICE third-party-licenses.md yunikorn-scheduler /
  19 |     USER 4444:4444

from docker version 27.1.1

suggested change: remove --platform=$TARGETPLATFORM in dockerfile
ref: https://docs.docker.com/reference/build-checks/redundant-target-platform/#examples

change:

  1. shim: RedundantTargetPlatform
  2. web:
  • RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior (line 32)
  • LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 36)
  • FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 20)
  • InvalidDefaultArgInFrom: Default value for ARG node:${NODE_VERSION}-alpine results in empty or invalid base image name (line 20)

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2799

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.18%. Comparing base (cc91552) to head (0c72c20).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
- Coverage   68.20%   68.18%   -0.03%     
==========================================
  Files          70       70              
  Lines        7606     7606              
==========================================
- Hits         5188     5186       -2     
- Misses       2211     2213       +2     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants