-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deltamin now defined in ice_in #63
Conversation
By the way tinyarea has been replaced by deltaminTarea...I am open to suggestions if you have a better variable name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add least add the new namelist to the namelist table in the documentation? I think it's useful to keep that up to date even if there is additional documentation needed elsewhere to be added later.
Could we find a shorter string than delatminTarea for the variable. That string really messes up some of the indentation and means we need to adjust a bunch of other lines too. We can do that, but nice if we don't have to.
Ok I will do it. I think finally I will have to introduce two deltamin (VP and EVP). |
@apcraig I am done. Please let me know if this is ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that DminTarea is an array computed initially and stored but DminUarea is computed on the fly each timestep and gridpoint.
If you wanted to use one deltamin namelist, you could do the following (psuedocode). Not suggesting it has to be implemented as one namelist, but it does make things more general and flexible in some ways.
real deltamin
real, parameter :: deltamin_spval = -1.2345e30_dbl_kind
real, parameter :: deltaminEVP = 1.0e-11_dbl_kind
real, parameter :: deltaminVP = 2.0e-9_dbl_kind
deltamin = deltamin_spval
...
read namelist
...
if (deltamin == deltamin_spval) then
if (kdyn == 1) deltamin = deltaminEVP
if (kdyn == 3) deltamin = deltaminVP
endif
@@ -2210,6 +2236,7 @@ subroutine input_data | |||
|
|||
1000 format (a20,1x,f13.6,1x,a) ! float | |||
1002 format (a20,5x,f9.2,1x,a) | |||
1003 format (a20,1x,f16.14,1x,a) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like here, you might want to have a G or E formatted output for deltamin since it's very small (e-9, e-11). Or multiple deltamin by 1e6 or 1e9 and then write out with F formatting?
Good point for the format. I just changed it. |
The new namelist also need to be added to doc/source/user_guide/ug_case_settings.rst in the correct group. These are alphabetical. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating documentation and moving evp_algorithm. The line after that also has to move with evp_algorithm that's "shared_mem_1d".
Thanks Tony. It should be ok now. |
Just FYI that a followup PR set the capping value to 0. for vp cases for backwards compatibility. The default was 1. for all dynamics options after this change but prior results had it set to 0. for vp cases. If we want to setup capping to 1. for vp and change answers, that's fine, lets just be clear about that. |
Thanks Tony. Sorry I didn't think about backward compatibility... |
Sounds good @JFLemieux73. I have changed the capping value to 1.0 for VP in #64 and documented there. |
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
deltamin now defined in ice_in.
@JFLemieux73
gx3 test (1 day). BFB for kdyn=1 (deltamin=1e-11) and kdyn=3 (deltamin=2e-9)
I need to do some work about the doc. I have noted in issue Improve the documentation for the dynamics CICE-Consortium/CICE#651 what needs to be done.