Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression issue introduced in 3.49.0 #4637

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Aug 14, 2024

A regression introduced by commit 686266c (first appeared in release 3.49.0) caused stacked, reversed column chart with all negative series to render outside of masked plot area and not be visible.

Reduce/simplify the calculation of zeroH.

Fixes #4630

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@rosco54 rosco54 marked this pull request as ready for review August 14, 2024 07:27
@junedchhipa junedchhipa merged commit 275d405 into apexcharts:main Aug 15, 2024
7 checks passed
@rosco54 rosco54 deleted the Issue_4630 branch August 16, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reversed stacked bar chart fails to load with all -ve data points
2 participants