Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 4645 #4646

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Fix issue 4645 #4646

merged 1 commit into from
Aug 17, 2024

Conversation

cocarmon
Copy link
Contributor

New Pull Request

Fix getShadeColor() handling of RGB values. Ensure hexToRgba receives a hex value by checking if the shadeColor() output is in RGB format; convert to hex if necessary before passing to hexToRgba.

Fixes # (issue)
#4645

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@junedchhipa junedchhipa merged commit 476df9e into apexcharts:main Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants