Some ideas on add_root_dictionary #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead tie name generation to target propeties OUTPUT_NAME and LIBRARY_OUTPUT_DIRECTORY.
|
@dennisklein thanks for the PR. It indeed touches some points I had on my TODO list ;-) (like deriving the output locations from the target itself). Will most probably take it eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to look at your CMake progress for O2. I have not looked at everything, but played a bit around with
add_root_dictionary. I thought I make a PR to communicate my ideas/thoughts about it. If you like anything, please take it as needed.Thanks for your work!