Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch useRenderGuard to an approach not accessing React's internals #11888

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jun 11, 2024

This switches useRenderGuard to an approach that is not accessing React's internals, and we should even safe some bundle size 🎉

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 332ffd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 11, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.63 KB (-0.15% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.41 KB (-0.13% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.98 KB (-0.13% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.2 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.29 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.37 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.57 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.64 KB (0%)
import { useMutation } from "dist/react/index.js" 3.54 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.77 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.21 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.4 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.96 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.61 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.02 KB (-0.97% 🔽)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.67 KB (-1.53% 🔽)
import { useReadQuery } from "dist/react/index.js" 3.33 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.27 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.23 KB (0%)

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 332ffd0
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66697fde48c0350008cc82da
😎 Deploy Preview https://deploy-preview-11888--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever! I'm really happy we're able to keep this around. Nice work!

@github-actions github-actions bot added the auto-cleanup 🤖 label Jun 11, 2024
@@ -1,4 +1,4 @@
{
"dist/apollo-client.min.cjs": 39620,
"dist/apollo-client.min.cjs": 39561,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@phryneas phryneas merged commit 7fb7939 into main Jun 12, 2024
42 checks passed
@phryneas phryneas deleted the pr/useRenderGuard branch June 12, 2024 11:14
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants