Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any reference to delay and load props #3806

Merged
merged 4 commits into from
Aug 17, 2018

Conversation

kamaltmo
Copy link
Contributor

As mentioned in this issue, apollographql/react-apollo#1875, these props seem to not exist or at least are non-functional. This PR is to reduce confusion when using the Query component.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

As mentioned in this issue, apollographql/react-apollo#1875, these props seem to not exist or at least are non-functional. This PR is to reduce confusion when using the `Query` component.
@apollo-cla
Copy link

@kamaltmo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@hwillson
Copy link
Member

Thanks for this @kamaltmo! I'm just digging into the background on why these were added to the docs when they aren't wired up in React Apollo. I'll post back shortly.

@hwillson
Copy link
Member

Backstory: apollographql/react-apollo#1875 (comment)

We'll move ahead with removing these.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @kamaltmo!

@hwillson hwillson merged commit 6788b39 into apollographql:master Aug 17, 2018
@kamaltmo kamaltmo deleted the patch-1 branch August 20, 2018 10:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants