Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server-side-rendering.md #4287

Merged
merged 4 commits into from
Jan 31, 2019
Merged

Conversation

jtassin
Copy link
Contributor

@jtassin jtassin commented Jan 6, 2019

In my opinion, this line will be more understandable with the JSON.stringify.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

According to me, it will be more understandable with the `JSON.stringify`
@apollo-cla
Copy link

@jtassin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@danilobuerger danilobuerger self-assigned this Jan 31, 2019
@danilobuerger
Copy link
Contributor

Thanks @jtassin

@danilobuerger danilobuerger merged commit 0725243 into apollographql:master Jan 31, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants