Preserve cache-and-network fetchPolicy when refetching. #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
May 20, 2019
| @@ -1070,7 +1071,7 @@ describe('ObservableQuery', () => { | |||
| const observable = queryManager.watchQuery({ | |||
| query: firstRequest.query, | |||
| variables: firstRequest.variables, | |||
| fetchPolicy: 'cache-and-network', | |||
| fetchPolicy: 'cache-first', | |||
There was a problem hiding this comment.
This test was literally just checking that cache-and-network gets overridden with network-only when refetching, so I think it's safe to check cache-first instead (if we accept the premise of this pull request).
Should help with the problem reported by @supercranky in this comment: #4636 (comment) The apparent reasoning for preserving the no-cache and network-only fetch policies is that refetching requires a "network" fetch policy, but I believe cache-and-network should also count as a "network" fetch policy, since it always attempts to fetch from the network in addition to fetching from the cache. Even if that network request fails, it may be useful (e.g. for offline usage) to return data from the cache.
benjamn
force-pushed
the
preserve-cache-and-network-fetchPolicy-when-refetching
branch
from
05c58f3
to
467146b
Compare
benjamn
deleted the
preserve-cache-and-network-fetchPolicy-when-refetching
branch
|
Hi @benjamn This change seems to be annoying for some of us (apollographql/react-apollo#3457 (comment)) Do you think it could be possible to pass a custom fetch policy to the "refetch" call? I want my query to have cache-and-network, but I want my refetch() promise to only resolve after the actual network refetch has been done, and this seems impossible currently |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with the problem reported by @supercranky in this comment.
The apparent reasoning for preserving the
no-cacheandnetwork-onlyfetch policies is that refetching requires a "network" fetch policy, but I believecache-and-networkshould also count as a "network" fetch policy, since it always attempts to fetch from the network in addition to fetching from the cache. Even if that network request fails, it may be useful (e.g. for offline usage) to return partial data from the cache, which is currently not possible when refetching, given therefetchmethod's behavior of overriding non-network/cache-friendlyfetchPolicys.