Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor markMutationResult to be a method of QueryManager #5649

Merged
merged 5 commits into from
Oct 15, 2020
Merged

Refactor markMutationResult to be a method of QueryManager #5649

merged 5 commits into from
Oct 15, 2020

Commits on Oct 14, 2020

  1. Refactor markMutationResult function in order to export it 

    This commit, through a small refactor, allows you to export the functions
that implement the cache update logics following a mutation.

The main changes:
  * creation of the public method `generateUpdateQueriesInfo` in QueryManager
  * removal of the generateUpdateQueriesInfo constant within the mutate function
  * creation & export of the `markMutationOptimistic` function
  * refactor & export of the `markMutationResult` function, the main
    change is the addition of the queryManager parameter in order to use the
    generateUpdateQueriesInfo function
    @morrys @benjamn
    morrys authored and benjamn committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    4e820f3 View commit details
    Browse the repository at this point in the history

  2. Make markMutationOptimistic a method of QueryManager.

    @benjamn
    benjamn committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1ca1a97 View commit details
    Browse the repository at this point in the history

  3. Make markMutationResult a method of QueryManager.

    @benjamn
    benjamn committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    3b57d82 View commit details
    Browse the repository at this point in the history

  4. Inline generateUpdateQueriesInfo into markMutationResult.

    @benjamn
    benjamn committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    159fc03 View commit details
    Browse the repository at this point in the history

  5. Further simplify mutation.updateQueries processing.

    @benjamn
    benjamn committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    0e83d09 View commit details
    Browse the repository at this point in the history