Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default implementation of ApolloCache#gc #5974

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Add default implementation of ApolloCache#gc #5974

merged 2 commits into from
Feb 21, 2020

Conversation

justinwaite
Copy link
Contributor

Hello there,

Just a quick PR based on the discussion over at #5966

Please try not to be too impressed by my 4 lines of code.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@justinwaite: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha - 4 lines of perfection @justinwaite 😂. Thanks!

@hwillson hwillson merged commit d42c280 into apollographql:master Feb 21, 2020
@justinwaite justinwaite deleted the patch-2 branch February 21, 2020 18:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants