Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop feuds by skipping cache writes for unchanged network results. #6448

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Stop feuds by skipping cache writes for unchanged network results. #6448

merged 3 commits into from
Jun 16, 2020

Commits on Jun 16, 2020

  1. Stop feuds by skipping cache writes for unchanged network results. 

    Ever since the big refactoring in #6221 made the client more aggressive
about triggering network requests in response to incomplete cache data
(when using a cache-first FetchPolicy), folks testing the betas/RCs have
reported that feuding queries can end up triggering an endless loop of
unhelpful network requests.

This change does not solve the more general problem of queries competing
with each other to update the same data in incompatible ways (see #6372
for mitigation strategies), but I believe this commit will effectively put
a stop to most cases of endless network requests.

See my lengthy implementation comment for more details, since this is a
non-obvious solution to a very tricky problem.

Fixes #6307.
Fixes #6370.
Fixes #6434.
Fixes #6444.
    @benjamn
    benjamn committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    df08097 View commit details
    Browse the repository at this point in the history

  2. Clear queryInfo.lastWritten{Result,Vars} on error.

    @benjamn
    benjamn committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    b0a100a View commit details
    Browse the repository at this point in the history

  3. Regression test for PR #6448.

    @benjamn
    benjamn committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    5aa0977 View commit details
    Browse the repository at this point in the history