react: MutationResult.client is always set #6617
Conversation
|
I believe this is backwards-compatible because |
glasser
force-pushed
the
glasser/mutation-result-client-always
branch
from
c6695f2
to
040a192
Compare
There was a problem hiding this comment.
Makes sense to me, and I agree that making an optional field of a provided object non-optional should be a compatible change. I say "provided object" because developers don't have to create these MutationResult objects themselves.
Also, we're about to release a minor version (3.1.0), so this kind of change should be even less of a surprise.
As far as I can tell, whenever a MutationResult is provided to the user of useMutation (or the component or HOC), it always contains a `client`; eg, OperationData.refreshClient checks this invariant. MutationResult is also used to type an internal state variable used by MutationData and useMutation; this one doesn't contain a `client`. This PR changes that variable to different type without `client`, and the actual exposed MutationResult now has a non-optional `client`. This makes it match `QueryResult`. Now TypeScript consumers of `useMutation` don't need to check to see if `client` exists before using it.
benjamn
force-pushed
the
glasser/mutation-result-client-always
branch
from
040a192
to
50d3217
Compare
|
This is officially available now in |
As far as I can tell, whenever a MutationResult is provided to the user of
useMutation (or the component or HOC), it always contains a
client; eg,OperationData.refreshClient checks this invariant.
MutationResult is also used to type an internal state variable used by
MutationData and useMutation; this one doesn't contain a
client. This PRchanges that variable to different type without
client, and the actual exposedMutationResult now has a non-optional
client. This makes it matchQueryResult.Now TypeScript consumers of
useMutationdon't need to check to see ifclientexists before using it.