Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider cache.modify a destructive method, like cache.evict. #6898

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Consider cache.modify a destructive method, like cache.evict. #6898

merged 3 commits into from
Aug 25, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Aug 25, 2020

Analogous to #6817, but for cache.modify in addition to cache.evict. Fixes #6896.

@benjamn benjamn added this to the Post 3.0 milestone Aug 25, 2020
@benjamn benjamn self-assigned this Aug 25, 2020
@benjamn benjamn merged commit 5b9581b into release-3.2 Aug 25, 2020
@benjamn benjamn deleted the consider-cache.modify-destructive-too branch August 25, 2020 18:12
@benjamn benjamn mentioned this pull request Aug 25, 2020
Closed
benjamn added a commit that referenced this pull request Aug 28, 2020
@benjamn
Ensure cache.{evict,modify} not wrapped more than once.
1a601d8 
Fixes a regression introduced by PR #6898.
@joshjg joshjg mentioned this pull request Oct 11, 2020
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@benjamn benjamn

Labels
🧪 has-tests
Projects
None yet
Milestone
Post 3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@benjamn