Respect errorPolicy for mutation and subscription results. #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreighton
approved these changes
Sep 11, 2020
benjamn
added a commit
that referenced
this pull request
Sep 11, 2020
Using the default ErrorPolicy of "none" for queries means no data will be written to the cache when a GraphQL result has errors. Queries can use errorPolicy:"ignore" and errorPolicy:"all" to ensure data is written to the cache in spite of GraphQL errors, but mutations and subscriptions were previously limited to the default policy, "none". This commit makes mutations and subscriptions respect the non-default "ignore" and "all" ErrorPolicy values, just as queries do, hopefully addressing #6965. Since these changes did not cause any tests to fail, clearly we need more tests of non-default ErrorPolicy usage by mutations and subscriptions.
benjamn
force-pushed
the
make-mutations-and-subscriptions-respect-error-policy
branch
from
87a26b4
to
acef8ca
Compare
benjamn
deleted the
make-mutations-and-subscriptions-respect-error-policy
branch
This was referenced Sep 11, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the default
ErrorPolicyof "none" for queries means no data will be written to the cache when a GraphQL result has errors.Queries can use
errorPolicy: "ignore"anderrorPolicy: "all"to ensure data is written to the cache in spite of GraphQL errors, but mutations and subscriptions were previously limited to the default policy, "none".This commit makes mutations and subscriptions respect the non-default "ignore" and "all"
ErrorPolicyvalues, just as queries do, hopefully addressing #6965.Since these changes did not cause any tests to fail, clearly we need more and better tests of non-default
ErrorPolicyusage by mutations and subscriptions.