Skip to content

Commit

Permalink
Round the ttl to an integer so that redis doesn't b0rk (#1323)
Browse files Browse the repository at this point in the history
Fixes #1306.
  • Loading branch information
raduachim authored and martijnwalraven committed Jul 10, 2018
1 parent 61b4939 commit e83dcbc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/apollo-datasource-rest/src/HTTPCache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class HTTPCache {
const body = await response.text();
const entry = JSON.stringify({ policy: policy.toObject(), body });

let ttl = policy.timeToLive() / 1000;
let ttl = Math.round(policy.timeToLive() / 1000);
// If a response can be revalidated, we don't want to remove it from the cache right after it expires.
// We may be able to use better heuristics here, but for now we'll take the max-age times 2.
if (canBeRevalidated(response)) {
Expand Down

0 comments on commit e83dcbc

Please sign in to comment.