Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user-defined GraphQLExtensions, add apollo-engine-reporting #1105

Merged
merged 6 commits into from
Jun 1, 2018

Conversation

glasser
Copy link
Member

@glasser glasser commented May 29, 2018

I started with #934 by @sebas5384 (which allows you to pass in your own extensions) and updated it for a new graphql-extensions API.

  • Actually call validationDidStart and parsingDidStart.

  • Use new graphql-extensions API which:

    • replaces fooDidEnd with a handler returned by fooDidStart
    • adds options to various methods
    • has a new willSendResponse method
    • requires you to construct the extension objects yourself
  • Make a better effort at consistently calling end handlers even on error

@glasser glasser mentioned this pull request May 29, 2018
4 tasks
@glasser glasser force-pushed the glasser/extensions-0.1.0 branch 4 times, most recently from 6c3e890 to ae9c187 Compare May 30, 2018 18:55
@glasser glasser changed the title [wip] New graphql-extensions API Allow user-defined GraphQLExtensions May 30, 2018
sebas5384 and others added 3 commits May 31, 2018 00:14
- Actually call validationDidStart and parsingDidStart.

- Use new graphql-extensions API which:
  - replaces fooDidEnd with a handler returned by fooDidStart
  - adds options to various methods
  - has a new willSendResponse method
  - requires you to construct the extension objects yourself (but make
    the external API for specifying extensions to ApolloServer be
    factories, because extensions are per request)

- Make a better effort at consistently calling end handlers even on error
@glasser glasser force-pushed the glasser/extensions-0.1.0 branch 2 times, most recently from 1623727 to be28483 Compare May 31, 2018 08:32
@glasser glasser changed the title Allow user-defined GraphQLExtensions Allow user-defined GraphQLExtensions, add apollo-engine-reporting May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants