Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect to FetcherRequestInit #376

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Add redirect to FetcherRequestInit #376

merged 3 commits into from
Nov 8, 2023

Conversation

rportugal
Copy link
Contributor

@rportugal rportugal commented Oct 24, 2023

Was present in previous Apollo REST Data Source versions, but seems to be missing on this one. It's part of the Fetch API (https://developer.mozilla.org/en-US/docs/Web/API/Request/redirect), so it should be safe to add here.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: baf5e55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/utils.fetcher Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I checked the typings libs for the 3 fetchers we test against and this is compatible with all of them. I also confirmed that any deviation from this type is indeed caught by our typings tests so this seems like a fine addition. Thanks!

@trevor-scheer trevor-scheer merged commit 7af650b into apollographql:main Nov 8, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants