Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping babel-eslint and pinning graphql-config #101

Merged
merged 2 commits into from
Jan 15, 2018

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Jan 15, 2018

I still dont have Renovate set up, so manually bumping a couple of libraries that have been giving us some trouble in Node v4/v5.

Pinning graphql-config to ~1.0.0 (no minors) because 1.1.0 introduces a dependency that doesn't quite work in Node v4/v5. I'm imagining that deprecating support for Node v4 should be a major version bump, otherwise we'll wait until both graphql-config and graphql-import support Node v4/v5/v6.

TODO:

  • [ ] Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass
  • [ ] Update CHANGELOG.md with your change
  • [ ] If this was a change that affects the external API, update the README

@jnwng jnwng changed the title Bumping babel-eslint Bumping babel-eslint and pinning graphql-config Jan 15, 2018
@jnwng jnwng merged commit 8c5052d into apollographql:master Jan 15, 2018
@jnwng jnwng deleted the jw/bump-eslint branch January 15, 2018 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant