-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File uploads - Nullability integration test #4708
Comments
nicholascioli
added a commit
that referenced
this issue
Mar 5, 2024
resolves #4708 This commit adds a test to ensure that non-nullable file uploads still work as expected.
nicholascioli
added a commit
that referenced
this issue
Mar 5, 2024
resolves #4708 This commit adds a test to ensure that non-nullable file uploads still work as expected.
6 tasks
nicholascioli
added a commit
that referenced
this issue
Mar 7, 2024
resolves #4708 This commit adds a test to ensure that non-nullable file uploads still work as expected.
nicholascioli
added a commit
that referenced
this issue
Mar 7, 2024
Existing integration tests for the file uploads plugin did not test for non-nullable uploads. As this is realistically the more common case, this commit adds a test to ensure that non-nullable files work as expected. This is necessary since the router does some substitution of the variables for the file upload case which might cause validation issues if not carefully tested. Fixes #4708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All of the current tests use a nullable Upload object, but most use-cases will probably make it non-nullable.
The text was updated successfully, but these errors were encountered: