Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unit tests for subgraph batching #4787

Conversation

nicholascioli
Copy link
Contributor

@nicholascioli nicholascioli commented Mar 11, 2024

This commit adds a few more unit tests for verifying the functionality of all helper methods and, where applicable, beefy methods pertinent to the subgraph batching initiative.

Note: This commit builds off of #4780 so @garypen please refer to this commit.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@nicholascioli nicholascioli self-assigned this Mar 11, 2024
@router-perf
Copy link

router-perf bot commented Mar 11, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added one NIT (tiny comment, consider but feel free to reject) to the batch assembly test and approved.

apollo-router/src/batching.rs Outdated Show resolved Hide resolved
This commit adds a few more unit tests for verifying the
functionality of all helper methods and, where applicable, beefy
methods pertinent to the subgraph batching initiative.
@nicholascioli nicholascioli force-pushed the nc/subgraph-batching/missing-unit-tests branch from 7e449e0 to 1bb35df Compare March 12, 2024 15:30
@nicholascioli nicholascioli marked this pull request as ready for review March 12, 2024 15:31
@nicholascioli nicholascioli merged commit be6d14d into garypen/2002-subgraph-batching Mar 12, 2024
11 of 12 checks passed
@nicholascioli nicholascioli deleted the nc/subgraph-batching/missing-unit-tests branch March 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants