Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[batching] tweak single cancellation point changes #4868

Merged

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Mar 27, 2024

These tweaks are enough (I think) for us to make progress.

Let's review together and then decide how to proceed.

Ref: #4661

These tweaks are enough (I think) for us to make progress.

Let's review together and then decide how to proceed.
@garypen garypen self-assigned this Mar 27, 2024
@router-perf
Copy link

router-perf bot commented Mar 27, 2024

CI performance tests

  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • large-request - Stress test with a 1 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • xlarge-request - Stress test with 10 MB request payload
  • step - Basic stress test that steps up the number of users over time

@garypen garypen changed the title tweak single cancellation point changes [batching] tweak single cancellation point changes Mar 27, 2024
@garypen garypen merged commit 853aabc into nc/subgraph-batching/single-cancel-spot Mar 27, 2024
13 checks passed
@garypen garypen deleted the garypen/cancellation-tweaks branch March 27, 2024 15:23
nicholascioli pushed a commit that referenced this pull request Mar 27, 2024
These tweaks are enough (I think) for us to make progress.

Let's review together and then decide how to proceed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant